-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add active lock reason to issue #2525
Conversation
I need some feedback on this. |
Hey so it would be good to see an integration test covering this, in IssuesClientTests in Octokit.Tests.Integration. If you want to add it to PullRequest as well, that would be great! But if you don't, add it as a new issue so we can track it 👍 |
Hey @JonruAlveus, thanks for the input. However, I can't seem to run all of integration tests. Am I missing something? |
If you head over to here there's instructions on how to set up test accounts for the integration tests to run in. You don't need all of the settings, but try to use a separate github account to your own as you could easily get yourself locked out of github for exceeding api rate limits 😄 I believe you need the first two as a minimum: OCTOKIT_GITHUBUSERNAME and OCTOKIT_GITHUBPASSWORD, which are set as environment variables on your machine. |
Thanks @JonruAlveus, I'll give it a go. I have updated the PR with a sample test. Will update when I can set up the test. |
Added CanAccessActiveLockReason on IssuesClientTest and the test is passing. |
2c99871
to
5588ea4
Compare
Hey @notauserx |
@nickfloyd line endings seems to be correct for the files I modified. |
Judging by the gitattributes documentation (effects section) (and I’m not an expert on this at all), when you got add or got commit, the line endings are set according to the file. So I guess you could change the line endings and they will just be sorted out when you add/commit. |
For sure... for .cs files as defined in our I used to config my local global, just in case the repo I am working in does not have All that to say, for *.cs files and all other files, we should follow what is defined in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick change around the enum value name - looks like a typo. This is looking good, let me know when you take it out of WIP / Draft, and we can get this merged in.
Co-authored-by: Nick Floyd <[email protected]>
@nickfloyd thanks for the review and the catch. I've committed your suggestion and removed wip from the name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes ❤️
release_notes: Adds active lock reason to issue |
Added LockReason enum, added activelockreason property to Issue class.
Fixes issue #2248