Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidying up DefineConstants #2538

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

JonruAlveus
Copy link
Collaborator

@JonruAlveus JonruAlveus commented Aug 10, 2022

fixes #2526

  • GITHUBJWT_HELPER_AVAILABLE - Removed as we now target netstandard2.0 and so does the github jwt package
  • NET_45 - Removed as nothing uses it
  • NO_SERIALIZABLE - Remove as it's for SimpleJson and it requires the Serializable attribute to work in netstandard.
  • HAS_DEFAULT_ENCODING - Removed as Encoding.GetEncoding(0) is the netstandard/netcore way of doing things
  • HAS_TYPEINFO - Removed as netstandard's System.Reflection supports both options. Retaining the version of the code which uses GetTypeInfo()
  • HAS_REGEX_COMPILED_OPTIONS - Keep as it doesn't appear to be to do with the .net version in use
  • HAS_ENVIRONMENT - Removed as netstandard supports both options. Changed to use the Environment version as it gives more info
  • HAS_SERVICEPOINTMANAGER - Removed as netstandard and net462 has TLS1.2 enabled by default (or system defaults). In the future, if TLS1.3 becomes the requirements, we will have to change code to handle this, which isn't desirable
  • NETFX_CORE - Don't want to touch simplejson!
  • SIMPLE_JSON_NO_LINQ_EXPRESSION - Don't want to touch simplejson!
  • SIMPLE_JSON_DYNAMIC - Don't want to touch simplejson!
  • SIMPLE_JSON_OBJARRAYINTERNAL - Don't want to touch simplejson!
  • SIMPLE_JSON_INTERNAL - Don't want to touch simplejson!
  • SIMPLE_JSON_READONLY_COLLECTIONS - Don't want to touch simplejson!
  • SIMPLE_JSON_REFLECTION_UTILS_PUBLIC - Don't want to touch simplejson!
  • SIMPLE_JSON_TYPEINFO - Don't want to touch simplejson!

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ❤️

@nickfloyd nickfloyd merged commit 176bf38 into octokit:main Aug 12, 2022
@nickfloyd
Copy link
Contributor

release_notes: Cleans up unused or unnecessary DefineConstants

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review/Cleanup DefineConstants in the projects
2 participants