Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserializing of Emoji types #2577

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

JonruAlveus
Copy link
Collaborator

Adding in assignable extensions to allow us to tell whether a type of IDictionary<T1,T2> which allows us to deserialise an object list to a dictionary. Currently if you use IDictionary<T1,T2> it is not recognised as a dictionary type and the body is wrapped as if it were an array of 1 object.

closes #2576

… IDictionary<T1,T2> which allows us to deserialise an object list to a dictionary. Currently if you use IDictionary<T1,T2> it is not recognised as a dictionary type and the body is wrapped as if it were an array of 1 object.
@nickfloyd nickfloyd merged commit 2701be5 into octokit:main Sep 20, 2022
@nickfloyd
Copy link
Contributor

release_notes: Fixes deserializing of Emoji types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miscellaneous Client - GetEmojis does not work
2 participants