Fix ActionsSelfHostedRunnersClient Delete Calls #2740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete___Runner
callsCancellationToken cancellationToken = default
toCreate___Token
calls to allow for an optional cancellation token.Behavior
Before the change?
Delete___Runner
methods would throw an exception caused by passing the wrong kind ofObject
to the underlyingDelete
call. We we're previously passingApiOptions
which are the wrong type and not relevant.After the change?
Delete___Runner
methods succeed.Create__Token
methods allow for passing aCancellationToken
and still succeed.Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Feature
Type: Documentation
Type: Maintenance