Use Addressable::URI instead of stdlib URI for normalization #1006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1005
Instead of trying to only escape the relevant fragments, this PR still applies escaping to all URLs, but does it with
Addressable::URI
, which is better at figuring out what needs to be escaped and what doesn't.Example:
It also have the advantage of using the same parser for every MRI versions which solves the parser discrepancies in #1005
@tarebyte what do you think?