Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faraday DEFAULT_EXCEPTIONS for when retry middleware is available #1546

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

DougEdey
Copy link
Contributor

@DougEdey DougEdey commented Feb 16, 2023

Resolves #1188


Behavior

Before the change?

  • Octokit would not retry on timeouts

After the change?

  • Octokit does retry on timeouts

Other information

  • It's pretty straightforward, I can see the original issue marks this as a breaking change.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No (I don't think so)

If Yes, what's the impact:

  • This could be a breaking change since Octokit will now retry on errors it didn't before, but Faraday retry middleware #1021 wasn't marked as a breaking change,

Pull request type

I want to mark this as a bug, but I can understand if it's a feature!

@DougEdey
Copy link
Contributor Author

cc @tjoyal

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DougEdey thank you for this change! ❤️

@nickfloyd nickfloyd added the Type: Feature New feature or request label Mar 9, 2023
@nickfloyd nickfloyd merged commit aa9aaa0 into octokit:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Increase the default Faraday retry exceptions
2 participants