fix: Remove the Faraday multipart warning and tweak the error message raised at runtime when Faraday Multipart is not installed #1712
+34
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In 7bc6dd5, a warning message was added to let users know that faraday-multipart is required when using Faraday 2.0. This warning is not very helpful, and may lead to projects adding the gem to their dependencies even if they don't need it, as the faraday-multipart middleware is only used for uploading license for GitHub entrepise. This patch will avoid printing the warning unnecessarily but also display a better error message when ultimately the call to `conn.request :multipart` fails. Fix octokit#1701
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Edouard-chin
changed the title
nickfloyd
approved these changes
Sep 17, 2024
nickfloyd
changed the title
|
Labeling as bug because of the poor user experience and noise that is getting logged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1701
Before the change?
At runtime, a Faraday error is raised and the message of what happened is not clear.
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!