Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Remove app methods that have been deprecated since v4.8.0 #1720

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

pbstriker38
Copy link
Contributor

Blocks #1718


Before the change?

  • Methods that were deprecated in v4.8.0 were still available.

After the change?

  • These methods are no longer available

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd nickfloyd added Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Oct 17, 2024
@nickfloyd nickfloyd changed the title Remove app methods that have been deprecated since v4.8.0 BREAKING CHANGE: Remove app methods that have been deprecated since v4.8.0 Oct 17, 2024
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pbstriker38, solid 🏕️ cleanup here on the docs and defunct methods. Thank you ❤️

@nickfloyd nickfloyd merged commit 57f8600 into octokit:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants