merge http params for application auth #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
D'oh duplicating effort. What do you think about #339 instead? |
|
I like your tests. Also |
|
looking in the code again it seems we both fix it on different layers. Maybe we should merge both pull requests? |
pengwynn
added a commit
that referenced
this pull request
Nov 14, 2013
…-authentication-bug-337 merge http params for application auth
|
You twisted my arm? 😄 Thanks for the patch. |
|
thanks again @pengwynn GOOD JOB! 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for issue #337
There are no tests, but the ones in the referenced issue. Please advice on how and where to add tests.
Thanks.