-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new CodeQL variants analysis endpoints, new code scanning repository rule, description updates, removes Copilot usage metrics endpoint #452
base: main
Are you sure you want to change the base?
Conversation
Was the |
I can't get the |
The update_dry_run check hasn't worked in some time; we've been merging without it. I don't have any knowledge on the Copilot API changes, though I suppose I would trust the process unless I had a reason to doubt it. @wolfy1339 are you comfortable with me merging as-is (with a breaking change in the commit message body)? |
I would suggest to add a deprecation like https:/octokit/openapi/blob/main/changes/2021-04-30-operation-code-scanning-list-alert-instances.json, if the endpoint is infact being deprecated. If we remove an endpoint without a breaking change then people will run into cryptic TypeScript errors when using https:/octokit/plugin-rest-endpoint-methods.js (used by |
The copilot endpoints are in beta, and are subject to change. I don't see this endpoint anywhere in the docs |
@kfcampbell can you find out what the status is with the endpoint? If we can expect it to be re-released soon again, I'd vote for not removing it temporarily |
I'm sorry, this slipped through the cracks for me. I've asked and will report back when I hear anything. |
It was intended to be a temporary decision to unship the endpoint; it will be added back in the near future. We should probably not remove it across all our repos at this point. |
@kfcampbell Do you have any update for the |
I found new changes in GitHub's official OpenAPI specifications and thought I'd let you know about it 👋🤖
I can't tell if the changes include fixes, features, breaking changes or just cache updates, you'll have to figure that out on yourself and adapt the commit messages accordingly to trigger the right release, see our commit message conventions.