Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle error thrown by verify method #914

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Nov 14, 2023

No description provided.

Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd nickfloyd merged commit 449b159 into main Nov 14, 2023
6 checks passed
@nickfloyd nickfloyd deleted the handle-verify-error branch November 14, 2023 21:21
Copy link
Contributor

🎉 This PR is included in version 12.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

nickfloyd pushed a commit that referenced this pull request Nov 14, 2023
* test: handle error thrown by `verify` method

* fix: handle error thrown by `verify` method

* test: remove `.only`
nickfloyd added a commit that referenced this pull request Nov 14, 2023
* fix: handle error thrown by `verify` method (#914)

* test: handle error thrown by `verify` method

* fix: handle error thrown by `verify` method

* test: remove `.only`

* lint fix

---------

Co-authored-by: Gregor Martynus <[email protected]>
nickfloyd added a commit that referenced this pull request Nov 14, 2023
* fix: handle error thrown by `verify` method (#914)

* test: handle error thrown by `verify` method

* fix: handle error thrown by `verify` method

* test: remove `.only`

* lint fix

---------

Co-authored-by: Gregor Martynus <[email protected]>
nickfloyd added a commit that referenced this pull request Nov 14, 2023
* update publish pattern to make sure maintenance branches are picked up

* fix: Handle verify error  (#915)

* fix: handle error thrown by `verify` method (#914)

* test: handle error thrown by `verify` method

* fix: handle error thrown by `verify` method

* test: remove `.only`

* lint fix

---------

Co-authored-by: Gregor Martynus <[email protected]>

---------

Co-authored-by: Gregor Martynus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants