Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): encode discriminator field only once #1232

Merged
merged 3 commits into from
May 3, 2024

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented May 2, 2024

Fixes #1229

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.87%. Comparing base (fbe6d9e) to head (b1ddda2).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1232      +/-   ##
==========================================
+ Coverage   73.80%   73.87%   +0.06%     
==========================================
  Files         189      189              
  Lines       12762    12772      +10     
==========================================
+ Hits         9419     9435      +16     
+ Misses       2802     2797       -5     
+ Partials      541      540       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernado ernado merged commit cbb350f into ogen-go:main May 3, 2024
14 checks passed
@tdakkota tdakkota deleted the fix/duplicate-discriminator branch May 3, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discriminator in oneOf unions appears twice in response
2 participants