Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: marshal pathItem and operation extentions #1269

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

prgres
Copy link
Contributor

@prgres prgres commented Jun 25, 2024

With entgo and entoas there is no easy way to attach custom extension to the ogen.Spec structure.

x-gen extentions logic was implemented here:

Addresses #1228

Copy link
Member

@tdakkota tdakkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports should be fixed and debug print should be removed.

It would be nice to have test to ensure that extensions are actually present in resulting JSON.

Anything else looks good to me.

spec.go Outdated Show resolved Hide resolved
@prgres
Copy link
Contributor Author

prgres commented Jun 27, 2024

@tdakkota concerns addressed 💅🏼

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.90%. Comparing base (31300cd) to head (c830164).
Report is 14 commits behind head on main.

Current head c830164 differs from pull request most recent head 4024c9f

Please upload reports for the commit 4024c9f to get more accurate results.

Files Patch % Lines
spec.go 72.72% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1269      +/-   ##
==========================================
+ Coverage   73.87%   73.90%   +0.03%     
==========================================
  Files         189      189              
  Lines       12807    12855      +48     
==========================================
+ Hits         9461     9501      +40     
- Misses       2801     2805       +4     
- Partials      545      549       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdakkota tdakkota enabled auto-merge June 27, 2024 20:46
@tdakkota tdakkota merged commit 01e42b7 into ogen-go:main Jun 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants