Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: hyperlink flag #1177

Closed
wants to merge 6 commits into from
Closed

feature: hyperlink flag #1177

wants to merge 6 commits into from

Conversation

dankeyy
Copy link

@dankeyy dankeyy commented Apr 12, 2023

adding a --hyperlink option like in ls
feel free to throw any comments at the code

Edit: it seems like your inline output is broken on master (is fine on latest release),
meaning even if output can be displayed on one-two lines, it will spread as one file per line (try running exa from master on the exa root dir, then try it the same with v0.10.1/ ls)

As far as I've tested, this is because of the upgrade to term_grid 0.2.0
since then, grid.fit_into_width(self.console_width) returns None for what would've been valid console_width in past versions.

I will at least match the behavior of hyperlink to regular exa, so that if/ when you do fix it, it'll work fine with the hyperlink flag aswell

also read my comments, especially on the new escape function

thanks

@dankeyy dankeyy changed the title Hyperlink feature: hyperlink flag Apr 12, 2023
@nonZero
Copy link

nonZero commented Apr 12, 2023

Refs #396

@ariasuni
Copy link
Collaborator

ariasuni commented Sep 6, 2023

Closing this, since exa is unmaintained (see #1243), and this has been merged in the active fork eza. Thanks!

@ariasuni ariasuni closed this Sep 6, 2023
Alhadis added a commit to Alhadis/OSC8-Adoption that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants