Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsolete icons #1178

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Replace obsolete icons #1178

merged 1 commit into from
Aug 3, 2023

Conversation

mtoohey31
Copy link
Contributor

@mtoohey31 mtoohey31 commented Apr 12, 2023

This pull request replaces icons that have been relocated whose old location has been marked as obsolete in nerd-fonts.

The tldr, as I understand it, is that the codepoints used by mdi characters were relocated around the start of 2022 because the original positions conflicted with certain Chinese characters, so they were moved in this nerd-fonts pull request. This pull request updates exa's hard-coded icon values to use the new codepoints. This change should be transparent to users as long as they've updated their font sometime in the last year.

The only difference I noticed was a slight difference between the new and old versions of the xml icon. On kitty, the old icon takes up two cells, messing up the filename's alignment:

2023-04-12T19:14:29,591563750-04:00

The new icon doesn't doesn't seem to do this:

2023-04-12T19:14:20,143546614-04:00

So I think this is an improvement, even though I didn't expect to see any change?

@mtoohey31
Copy link
Contributor Author

Looks like the difference I was talking about at the end there is caused by this: ryanoasis/nerd-fonts#1061. Like I mentioned above though, I think this change is in our favour since the smaller icon prevents the columns from becoming misaligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants