Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert enum choices to integer choices in Daily Rounds #2462

Merged

Conversation

DraKen0009
Copy link
Contributor

@DraKen0009 DraKen0009 commented Sep 17, 2024

Proposed Changes

  • Update roundsType
  • Update ConsciousnessType
  • Update PupilReactionType
  • Update LimbResponseType
  • Update RythmnType
  • Update VentilatorInterfaceType
  • Update VentilatorModeType
  • Update VentilatorOxygenModalityType
  • Update InsulinIntakeFrequencyType

Associated Issue

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Linting Complete

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

@sainak
Copy link
Member

sainak commented Sep 18, 2024

@DraKen0009 update the pr title

@DraKen0009 DraKen0009 changed the title updated the reference for timeout value in function Convert enum choices to integer choices in Daily Rounds Sep 18, 2024
@DraKen0009 DraKen0009 marked this pull request as ready for review September 18, 2024 11:42
@DraKen0009 DraKen0009 requested a review from a team as a code owner September 18, 2024 11:42
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@e48887d). Learn more about missing BASE report.
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
care/facility/api/viewsets/daily_round.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2462   +/-   ##
==========================================
  Coverage           ?   64.32%           
==========================================
  Files              ?      240           
  Lines              ?    13620           
  Branches           ?     1942           
==========================================
  Hits               ?     8761           
  Misses             ?     4501           
  Partials           ?      358           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit d5a2278 into ohcnetwork:develop Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert enum choices to integer choices in Daily Rounds
4 participants