Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use random uuid suffix in cover image key with size validation #2472

Merged
merged 6 commits into from
Sep 21, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Sep 19, 2024

Proposed Changes

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 40.38462% with 31 lines in your changes missing coverage. Please review.

Project coverage is 64.82%. Comparing base (8513421) to head (d73dee2).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
care/utils/models/validators.py 40.00% 27 Missing ⚠️
care/facility/api/serializers/facility.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2472      +/-   ##
===========================================
- Coverage    64.90%   64.82%   -0.09%     
===========================================
  Files          242      242              
  Lines        13809    13858      +49     
  Branches      1906     1920      +14     
===========================================
+ Hits          8963     8983      +20     
- Misses        4468     4497      +29     
  Partials       378      378              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak sainak force-pushed the sainak/feat/random-cover-image-id branch from 4efa55b to f5ffc2a Compare September 20, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change backend logic for setting the cover image key
3 participants