Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/8029/modify nurse access to consultation page #8727

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Sulochan-khadka
Copy link
Contributor

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Sulochan-khadka Sulochan-khadka requested a review from a team as a code owner October 6, 2024 14:44
Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 1962290
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670991e55598b00008f20564
😎 Deploy Preview https://deploy-preview-8727--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Oct 8, 2024

image

  • buttons are disabled for the consultation card to which the users have access to, which is not the expected behavior, they should be allowed to access it, check the comment and issues once again @Sulochan-khadka

@Sulochan-khadka
Copy link
Contributor Author

image

  • buttons are disabled for the consultation card to which the users have access to, which is not the expected behavior, they should be allowed to access it, check the comment and issues once again @Sulochan-khadka

Apologies for the incorrect changes.
The issue is not very clear , which is why i asked there but was no reply, therefore i went ahead and implemented whatever i understood. It would be great of you if you kindly provide the steps to reproduce the issue.

@nihal467
Copy link
Member

nihal467 commented Oct 10, 2024

  • Any non-admin users, should be able to access only the consultation card from facility there are linked, if the patient has any consultation history from facility where they are not linked, then the button on that particular card should be disabled

step 1: Admit Patient A to Facility A, then discharge them from Facility A. Repeat this process for Facility B and Facility C.
Step 2: After these admissions and discharges, Patient A will have a consultation history from Facilities A, B, and C.
Step 3: Log in with a nurse's user ID that is linked only to Facilities A and B.
Step 4: Now re-admit Patient A to one of the facilities (either A or B) where the nurse is linked.
Step 5: Access Patient A’s consultation history. In the consultation cards, the button in the consultation card related to Facility C should be disabled, as the nurse is not linked to Facility C.

@Sulochan-khadka
Copy link
Contributor Author

  • Any non-admin users, should be able to access only the consultation card from facility there are linked, if the patient has any consultation history from facility where they are not linked, then the button on that particular card should be disabled

step 1: Admit Patient A to Facility A, then discharge them from Facility A. Repeat this process for Facility B and Facility C. Step 2: After these admissions and discharges, Patient A will have a consultation history from Facilities A, B, and C. Step 3: Log in with a nurse's user ID that is linked only to Facilities A and B. Step 4: Now re-admit Patient A to one of the facilities (either A or B) where the nurse is linked. Step 5: Access Patient A’s consultation history. In the consultation cards, the button in the consultation card related to Facility C should be disabled, as the nurse is not linked to Facility C.

Thankyou very much for the much needed explaination. I have made some changes, kindly review them. And let me know in case of modifications.

@nihal467
Copy link
Member

@Sulochan-khadka
image

  • Now, the district admin itself is blocked from accessing the button in consultation card, before requesting another review, make sure admins (district and state admin) have no restriction at all and non-admins (doctor, nurse, all other users) have restrictions are per issue

@Sulochan-khadka
Copy link
Contributor Author

Sulochan-khadka commented Oct 14, 2024

@Sulochan-khadka image

  • Now, the district admin itself is blocked from accessing the button in consultation card, before requesting another review, make sure admins (district and state admin) have no restriction at all and non-admins (doctor, nurse, all other users) have restrictions are per issue

The logic seems pretty convincing that the consultation facilities are checked whether it matches with the allowed facilities of the user.

Screenshot 2024-10-15 at 1 54 11 AM

However, the problem you stated occurs when the facility is no more linked with the district admin and i think that is correct since it may happen that some facilities get linked to different district admins and therefore, the previous admin should not have the access to it. Right?!
Screenshot 2024-10-15 at 2 08 02 AM

Also "View / Upload Consultation Files" should also have same added condition right? That if the user is not allowed a facility, it should not be able to interact with the consultation records. Right?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify non-admin users access to the patient consultation record
3 participants