Updated UI for facility cards and avatar component #8782
+84
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying care-fe with
|
| Latest commit: |
164c3b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96cb46c3.care-fe.pages.dev |
| Branch Preview URL: | https://minor-ui-changes.care-fe.pages.dev |
CARE
|
||||||||||||||||||||||||
| Project |
CARE
|
| Run status |
|
| Run duration | 03m 22s |
| Commit |
|
| Committer | Shivank Kacker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
124
|
|
In the updated UI, when the bed capacity exceeds the limit, the text turns into a red badge, which I feel may not look good. I suggest that when the facility is over bed capacity, the text should be made bold and the danger color applied, which might resemble the style shown in the screenshot below.
@shivankacker can you ask around the team for a opinion and let me know, which will the updated UI |
|
@nihal467 thought of this too, let me ask the team |
|
@shivankacker once the PR is ready for test, change the label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist