Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix userinfo request method #563

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JUVOJustin
Copy link

All Submissions:

Changes proposed in this Pull Request:

Change the userinfo request method from POST to GET. This is causing issues with some identity providers like cloudflare since the recommended method is GET.

How to test the changes in this Pull Request:

Just test idp´s as usual

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Changed userinfo endpoint request to GET as this is the recommended method by The OpenID Foundation. Implicitly solves authentication issues with cloudflare zero trust.

@JUVOJustin JUVOJustin changed the title Fix request method Fix userinfo request method Aug 22, 2024
@JUVOJustin
Copy link
Author

Is there anything I can do to unblock this? It is such a minor patch which would solve OpenID auth especially for users that use cloudflare. Would love to see this in core.

If there is anything i can do to unblock pls let me know.

@timnolte
Copy link
Collaborator

At this point in the coming weeks I will be submitting my final patch for this plugin. At which point I'll be looking for new maintainers. I no longer have the energy for WordPress and the toxicity of Matt Mullenweg permeating the WordPress community. If there are no reputable maintainers that step up to take over this plugin then it will more than likely die off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants