Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-Agent is hard coded #301

Closed
bdemers opened this issue Mar 3, 2022 · 1 comment
Closed

User-Agent is hard coded #301

bdemers opened this issue Mar 3, 2022 · 1 comment
Assignees
@arvindkrishnakumar-okta

Comments

@bdemers
Copy link
Contributor

bdemers commented Mar 3, 2022

See:

okta-idx-java/api/src/main/java/com/okta/idx/sdk/api/client/BaseIDXClient.java

Line 71 in 1f2af5e

private static final String USER_AGENT_HEADER_VALUE = "okta-idx-java/2.0.0";

The version should get picked up automatically if you include an META-INF/okta/version.properties file

For example:
https:/okta/okta-jwt-verifier-java/blob/c3e44c142472fe34e6eaac1443b9a75f7c2e7368/impl/src/main/resources/META-INF/okta/version.properties

And enabler version filtering in the pom:
https:/okta/okta-jwt-verifier-java/blob/c3e44c1/impl/pom.xml#L123-L129
Merged
@arvindkrishnakumar-okta
Copy link
Contributor

Will be fixed as part of #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arvindkrishnakumar-okta arvindkrishnakumar-okta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdemers @arvindkrishnakumar-okta