Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

[feat] Add type definitions to @okta/jwt-verifier #393

Closed
2 tasks done
Toxicable opened this issue Feb 24, 2019 · 10 comments · Fixed by #979
Closed
2 tasks done

[feat] Add type definitions to @okta/jwt-verifier #393

Toxicable opened this issue Feb 24, 2019 · 10 comments · Fixed by #979

Comments

@Toxicable
Copy link

I'm submitting this issue for the package(s):

  • jwt-verifier

I'm submitting a:

  • Feature request

Current behavior

There are no type definitions for this package

Expected behavior

There to be type definitions for this package

Minimal reproduction of the problem with instructions

N/A

Extra information about the use case/user story you are trying to implement

N/A

Environment

N/A

@elecompte60
Copy link

Please!
These are widely used libraries from a large technology company. There's no reason these libraries should not include proper Typescript type signatures.

@bretterer
Copy link
Collaborator

@Toxicable & @elecompte60 - Thanks for your enhancement request for type definitions. This is on our roadmap to investigate. I have no information on a date of release at this time, but keep an eye on this issue for updates.

@shellscape
Copy link

@bretterer how's that roadmap looking now? okta-auth-js got types in.

@swiftone
Copy link
Contributor

TS support has moved from "something we are considering" to "something we are committed to doing".

okta-auth-js, okta-react, okta-angular, and okta-vue (PR under review) are converted to some real level of TS support. The line before jwt-verifier is definitely shorter, but I don't have a specific timeline yet for jwt-verifier getting the conversion.

@swiftone
Copy link
Contributor

Internal ref: OKTA-279270

@ryansonshine
Copy link
Contributor

@swiftone are you open to accepting a PR from the community on this one?

@swiftone
Copy link
Contributor

@ryansonshine - Of course! I can't promise anything, of course, without first seeing the code, but we welcome and appreciate contributions. Please make sure to sign our Contributor License Agreement (CLA) found here: https://developer.okta.com/cla/

Thanks for the interest!

@ryansonshine
Copy link
Contributor

Type definitions being submitted to DefinitelyTyped in the interim: DefinitelyTyped/DefinitelyTyped#51418

@swiftone
Copy link
Contributor

swiftone commented Mar 3, 2021

Just touching on this PR as the team discussed it during sprint planning and are looking to get it attention.

@shellscape
Copy link

I was hesitant to post this, and it should not be misread as a denigration to those who give their time freely - It's a bit bananas that open source contributions are tied to corporate sprint planning within the owning company. Terrible way to run open source projects, doesn't reflect well on Okta's understanding of open source.

denysoblohin-okta pushed a commit that referenced this issue Mar 22, 2021
Updates jwt-verifier with type definitions

Resolves: #393
denysoblohin-okta pushed a commit that referenced this issue Mar 24, 2021
Updates jwt-verifier with type definitions

Resolves: #393
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants