Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove query function:QueryProtocolVersion #481

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

summerpro
Copy link
Contributor

@summerpro summerpro commented Dec 9, 2020

From:cosmos/ethermint#575

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@summerpro summerpro changed the title delete query function:QueryProtocolVersion delete query function:QueryProtocolVersion, mv version.go to types/ Dec 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #481 (1fae934) into dev (6c7c1f4) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #481   +/-   ##
=======================================
  Coverage   68.24%   68.24%           
=======================================
  Files         254      253    -1     
  Lines       13769    13769           
=======================================
  Hits         9396     9396           
  Misses       3870     3870           
  Partials      503      503           
Impacted Files Coverage Δ
app/rpc/namespaces/eth/api.go 0.00% <0.00%> (ø)
app/rpc/namespaces/web3/api.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7c1f4...1fae934. Read the comment docs.

@zhongqiuwood zhongqiuwood changed the title delete query function:QueryProtocolVersion, mv version.go to types/ remove query function:QueryProtocolVersion Dec 9, 2020
@zhongqiuwood zhongqiuwood merged commit 50352df into dev Dec 9, 2020
@zhongqiuwood zhongqiuwood deleted the ray/rpc-protocol-version branch December 9, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants