Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Matlab support to decoupled repository #3135

Closed
wants to merge 3 commits into from
Closed

Migrate Matlab support to decoupled repository #3135

wants to merge 3 commits into from

Conversation

rleigh-codelibre
Copy link
Contributor

@rleigh-codelibre rleigh-codelibre commented Apr 30, 2018 •
edited
Loading

This is now decoupled in this repository:
https:/ome/bio-formats-matlab

Testing: Ensure that the travis and appveyor builds remain green.

CI changes:

  • The CI master Jenkins job for matlab will go red; this job should be disabled in favour of the gitlab-ci matlab support for the decoupled repository in Add automated tests microscopepony/bio-formats-matlab#3 (once merged)
  • The merge, latest and release jobs can no longer call the ant dist-matlab and dist-octave targets in these jobs:
    • BIOFORMATS-DEV-merge-build
    • BIOFORMATS-DEV-merge-build-win
    • BIOFORMATS-DEV-latest
    • BIOFORMATS-DEV-latest-win
    • BIOFORMATS-DEV-release

snoopycrimecop and others added 3 commits April 18, 2018 16:14
@snoopycrimecop
Update POM version numbers to 5.9.0-SNAPSHOT
97e3bb9 
Repository: openmicroscopy/bioformats
Already up-to-date.

Generated by BIOFORMATS-DEV-latest-version-bump#73 (https://ci.openmicroscopy.org/job/BIOFORMATS-DEV-latest-version-bump/73/)
@dgault
Merge pull request #3128 from snoopycrimecop/develop/latest/version_bump
60045cc 
Update POM version numbers to 5.9.0-SNAPSHOT
Remove Bio-Formats Matlab support
be1a93d 
This is now decoupled in this repository:
https:/ome/bio-formats-matlab
@sbesson
Copy link
Member

sbesson commented Apr 30, 2018

In addition to the CI infrastructure changes mentioned above, similar questions than bio-formats-documentation about the impact of these changes on the testing, integration and release process would be worth detailing in the reference card/document and discussing with the rest of the Formats team before this can be evaluated. In the meantime, I propose to swithc the base branch to east for initial evaluation. Also can the title be updated as it reads as if we are dropping support for MATLAB?

@rleigh-codelibre rleigh-codelibre changed the title Remove Bio-Formats Matlab support Migrate Matlab support to decoupled repository Apr 30, 2018
@rleigh-codelibre
Copy link
Contributor Author

rleigh-codelibre commented Apr 30, 2018 •
edited
Loading

The intention for opening against develop is for this to be removed for 5.9.0/the next stable release, which is why it's not open against east. Same as for the documentation removal.

@rleigh-codelibre
Copy link
Contributor Author

@sbesson @joshmoore See https://trello.com/c/rX56S0vk/20-decouple-matlab and above for the impact on jobs. At a minimum, the targets need removing from the merge and merge-win jobs to review the PR, and then latest, latest-win and release prior to merging.

@rleigh-codelibre rleigh-codelibre changed the base branch from develop to east April 30, 2018 15:57
@sbesson
Copy link
Member

sbesson commented Jul 6, 2018

Closing to get the 5.9.0 changes from #3180 integrated and the east-ci builds passing.

@sbesson sbesson closed this Jul 6, 2018
@rleigh-codelibre rleigh-codelibre mentioned this pull request Jul 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleigh-codelibre @sbesson @snoopycrimecop @dgault