Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve description of omero metadata #191

Merged
merged 3 commits into from
Jul 10, 2023
Merged

improve description of omero metadata #191

merged 3 commits into from
Jul 10, 2023

Conversation

giovp
Copy link
Contributor

@giovp giovp commented Apr 27, 2023

Currently, the omero metadata section in the specs could be a bit more descriptive, this is a small attempt.

This info was kindly summarized by @will-moore here: ome/ome-zarr-py#261 (comment)

EDIT: while this PR is purely to improve documentation, might be related to potential relaxation of omero metadata as discussed in #192

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2023

Automated Review URLs

@joshmoore
Copy link
Member

Thanks, @giovp! (https://ngff--191.org.readthedocs.build/latest/index.html#omero-md)

If no one else has any comments, I'll move to get this in.

@will-moore
Copy link
Member

Looks good.

Although we normally wouldn't make changes to a spec after release, this extra info could be added back to the v0.4 spec and might be useful?

But not a blocker!

@will-moore
Copy link
Member

Also with #192 proposed, this change in latest would be updated again before release, so it would be good to have this description in the v0.4 spec, where it won't change.

@giovp giovp mentioned this pull request Jun 15, 2023
@giovp
Copy link
Contributor Author

giovp commented Jun 15, 2023

sorry for radio silence @will-moore @joshmoore , I have time now, shall I just add the info as optional as discussed in #192 ? I yes, I can then submit changes to IO in ome-zarr-py . Let me know!

@will-moore
Copy link
Member

I would copy what you have now to the v0.4 spec - since it describes that spec and is worth having there. Then (probably in #192) update it in the in latest/index.bs according to the proposed changes there.
Probably easiest to keep them as separate PRs since this one just documents current state, but #192 is a change. I don't expect that to take a whole lot longer but you never know!

@giovp
Copy link
Contributor Author

giovp commented Jul 6, 2023

done, added it to 0.4

@will-moore will-moore merged commit 99b8765 into ome:main Jul 10, 2023
1 check passed
@will-moore
Copy link
Member

Great, thanks!

github-actions bot added a commit that referenced this pull request Jul 10, 2023
improve description of omero metadata

SHA: 99b8765
Reason: push, by @will-moore

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to d-v-b/ngff that referenced this pull request Aug 1, 2023
improve description of omero metadata

SHA: 99b8765
Reason: push, by @d-v-b

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@joshmoore joshmoore added this to the 0.4 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants