Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-2 Updates #261

Merged
merged 10 commits into from
Sep 13, 2024
Merged

RFC-2 Updates #261

merged 10 commits into from
Sep 13, 2024

Conversation

joshmoore
Copy link
Member

@joshmoore joshmoore commented Sep 11, 2024

(cc: @normanrz)

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Automated Review URLs

@joshmoore
Copy link
Member Author

Leaving this open with the hope to get @yarikoptic's re-review in.

@sbesson
Copy link
Member

sbesson commented Sep 11, 2024

If this is changing the URLs, the content of review 1b or RFC-2 might need to be slightly amended as it is linking to specific anchor of the review 1 via hyperlink and these would be broken by the renaming

@joshmoore
Copy link
Member Author

Ah, thanks for the heads up, @sbesson. I'll review. My experience with #258 was now that everything is in the markdown TOC we should be able to get good link checking if we omit the .html ending. I'll review all the files to this end.

@joshmoore joshmoore merged commit 10b4fb0 into ome:main Sep 13, 2024
9 checks passed
@joshmoore joshmoore deleted the rfc-2-updates branch September 13, 2024 09:46
github-actions bot added a commit that referenced this pull request Sep 13, 2024
RFC-2 Updates

SHA: 10b4fb0
Reason: push, by @joshmoore

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants