Convert the user bar into a helper #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-KM
force-pushed
the
feature/helper_user_bar
branch
3 times, most recently
from
c15f54c
to
fbfb163
Compare
|
The last commit avoids to update old themes, but the check for the user bar should be done when the helper is not used. |
|
I like this change, but I think we're going to wait until post-1.0 for it. |
Daniel-KM
force-pushed
the
feature/helper_user_bar
branch
from
d94ad14
to
ab0024c
Compare
|
Rebased. |
Daniel-KM
force-pushed
the
feature/helper_user_bar
branch
from
ab0024c
to
a4e23c6
Compare
|
Rebased. |
|
I'm understanding the change correctly that the bar will render with no theme changes, but switching over to use the helper is required to get the always/never/logged-in switch to work, yes? |
|
Last year, the idea was to avoid the upgrade of themes, so the upgrade works with any theme, and that's why the radio uses values "-1", "0", and "1", like a checkbox. These values can be changed if you want to require a change in themes. |
kimisgold
added a commit
to omeka-s-themes/centerrow
that referenced
this pull request
Jul 31, 2018
kimisgold
added a commit
to omeka-s-themes/thedaily
that referenced
this pull request
Jul 31, 2018
kimisgold
added a commit
to omeka-s-themes/cozy
that referenced
this pull request
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the previous pull request, I converted the user bar into a helper, so it is possible to add new tools in it. In fact, there are two ways to add new tools: a helper, so it's possible to upgrade the https:/omeka/plugin-EditLink, or a trigger, or even a block, but it's simpler via a helper and modules for now.
Note that this change requires an update to the official themes, since the user bar is now just
echo $this->userBar();(the partial is still available, but it requires a value for "user" and checks are not done). I can push this update if needed.