Implemented module page template and module block template #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Letting modules provide these across all themes seems like a fine idea. I did merge this, though one thing does occur to me now: you're merging the module templates into the theme's config... should it be the other way around, just a flipping of the arguments to array_merge_recursive? We often have themes be the highest-priority override. |
Daniel-KM
pushed a commit
to Daniel-KM/Omeka-S
that referenced
this pull request
Jul 11, 2024
zerocrates
added a commit
that referenced
this pull request
Jul 15, 2024
Fixed injection of module templates in theme with duplicate names (fix #2200).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The possibility to create multiple templates for blocks is very practical. There is just a last point: let modules create templates too. For example a module can implement a specific template for browse preview, whatever the theme is.
This feature is implemented in the new version of the module BlockPlus, but it should be usable by any module.
Technically, i prefered to inject the module templates (a list of key-value pairs for path/label) inside the theme data because it is the simplest way, but it can be done in a heavy way.