Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OMI_audio_emitter #1
OMI_audio_emitter #1
Changes from 2 commits
2cae7b0
d2248c9
524df3e
f353a5b
808dae1
5f32b79
7f3a577
87c700d
56a3d3b
73720dc
078b856
8249dc6
525b335
06c81d4
7d79f9b
4c0ebc6
aaafdf3
9ca0547
0767da7
3b30b9b
5fada8b
df24720
8d995c1
88fbc60
32c29d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In glTF 2.0 core spec, all angles are in radian. Should we follow it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second radians.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I represented this correctly. The maximum is 2PI radians then. Idk how to represent that in JSON schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default value should be rounded down at 6 decimal places and maximum value should be rounded up at 6 decimal places to deal with floating point precision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also clarify with the Khronos Working Group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on this discussion about the yfov and the punctual spotlight spec. I think we should go with a maximum and minimum value of
6.283185307179586
. We can also write in the readme/description that the maximum value is2 * PI
.This will work just fine in Javascript btw:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made this change now. I think it should be fine, but could use a second opinion.