Replace OMI_collider with OMI_physics_shape #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
OMI_physics_shape
branch
from
17fb261
to
6e03dc7
Compare
aaronfranke
force-pushed
the
OMI_physics_shape
branch
2 times, most recently
from
f78dea4
to
767843b
Compare
aaronfranke
force-pushed
the
OMI_physics_shape
branch
from
767843b
to
20e6e99
Compare
aaronfranke
force-pushed
the
OMI_physics_shape
branch
4 times, most recently
from
fb8baef
to
4e57816
Compare
antpb
approved these changes
Jun 22, 2023
Vote passes with 7 in favor none in opposition. |
aaronfranke
force-pushed
the
OMI_physics_shape
branch
from
4e57816
to
877830a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the discussions that took place in the 2023-06-07 Khronos 3D formats IP-free physics meeting and the 2023-06-08 OMI glTF group meeting. There was a desire to separate the concerns of defining the shape from its behavior such as static, kinematic, rigid, trigger, etc. This means taking
OMI_collider, removing the independent behavior, removingisTrigger, and renaming it toOMI_physics_shape.These physics shapes could also be used by other extensions if desired, since all they do is define a shape compatible with a physics engine.
This breaks compatibility with all implementations, therefore automatically demoting the specs to Stage 1.