Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OMI_physics_joint referring to outdated body types #192

Conversation

aaronfranke
Copy link
Contributor

I accidentally forgot to update OMI_physics_joint when I made #183. This PR fixes that.

Note: There will be further changes after this for alignment to Microsoft joints and alignment to what Khronos has stated they want, but this PR is just fixing the immediate problem of OMI_physics_joint not being consistent with OMI_physics_body.

Copy link
Contributor

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have review this sync. @lyuma can you be the other reviewer? Others welcome

@aaronfranke aaronfranke merged commit ae5da6b into omigroup:main Sep 21, 2023
1 check passed
@aaronfranke aaronfranke deleted the omi-physics-joint-dynamic-no-char-vehicle branch September 21, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants