create a account-archived page on web for archived users to export data #4355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jacksonh
reviewed
Aug 30, 2024
|
|
||
| try { | ||
| // Make a GET request to the /export endpoint | ||
| const response = await fetch('/api/export', { |
There was a problem hiding this comment.
What happens if they click this multiple times?
There was a problem hiding this comment.
There are two cases:
- If the export task is running, clicking this multiple times won't create multiple tasks and just return
200. Probably we should return202instead - If the export tasks is failed/completed, clicking this multiple times will firstly check if the user has exceed the export quota(3 times in a day)
2a. if not exceed, create a new export task
2b. if exceed, failed and return400
There was a problem hiding this comment.
great!
Is there any way in API to get the status of the export?
There was a problem hiding this comment.
Yeah, we can reuse the same export API by providing different status code like 200 or 204. Alternatively there is a /task/{{id}} API which could be used to query the status of a task
There was a problem hiding this comment.
I think probably I will just reuse the /export API and use the status code and state in the response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.