Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cli support for components #60

Merged
merged 17 commits into from
Aug 3, 2020

Conversation

Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Jul 8, 2020

What this PR does:

Adds support for components.

Which issue(s) this PR fixes:

Fixes onepanelio/onepanel#395

Special notes for your reviewer:

rushtehrani and others added 9 commits June 30, 2020 18:36
…ing used "artifactRepositoryIS3nsecure" -> "artifactRepositoryIS3Insecure"
clean: added methods with variadic function arguments to simplify caller logic
       used filepath.join to simplify statements that appended os.PathSeparator
feat: Support resource limits in nodePoolOptions
… modeldb. This will allow it to use other variable values if they exist. E.g. it could use database configuration from the database section, or you can manually set it by providing the values.
@Vafilor Vafilor changed the title Feat/onepanelio.core.395 components feat: add cli support for components Jul 21, 2020
@Vafilor Vafilor marked this pull request as ready for review July 21, 2020 22:03
@rushtehrani rushtehrani added this to the v0.12.0 milestone Jul 23, 2020
@rushtehrani rushtehrani changed the title feat: add cli support for components feat: Add cli support for components Jul 24, 2020
…ing used "artifactRepositoryIS3nsecure" -> "artifactRepositoryIS3Insecure"
clean: added methods with variadic function arguments to simplify caller logic
       used filepath.join to simplify statements that appended os.PathSeparator
… modeldb. This will allow it to use other variable values if they exist. E.g. it could use database configuration from the database section, or you can manually set it by providing the values.
…anelio/cli into feat/onepanelio.core.395-components
@Vafilor Vafilor merged commit 4242d79 into dev Aug 3, 2020
@Vafilor Vafilor deleted the feat/onepanelio.core.395-components branch January 11, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants