Speed up seed generation from 494 ns/op to 3 ns/op #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #190
Description
Use
circlehash.Hash64Uint64x2()
which accepts two uint64 values to hash. This avoids the need to create a new 16-byte slice and concatenation.This code block is eliminated:
Benchmark comparison on Haswell CPU with Go 1.16.9:
Hash64Uint64x2() is compatible with Hash64() for 16-byte inputs (given same inputs, they produce identical digests).
main
branchFiles changed
in the Github PR explorer