Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a comparison method for storage IDs #192

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Add a comparison method for storage IDs #192

merged 1 commit into from
Oct 26, 2021

Conversation

turbolent
Copy link
Member

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added the enhancement New feature or request label Oct 26, 2021
fxamacker
fxamacker approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@turbolent turbolent merged commit 9c5a643 into main Oct 26, 2021
@turbolent turbolent deleted the bastian/storage-id-comparison branch October 26, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxamacker fxamacker fxamacker approved these changes

@SupunS SupunS Awaiting requested review from SupunS

@ramtinms ramtinms Awaiting requested review from ramtinms ramtinms is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @fxamacker