Use non-global rand.Rand and add -seed flag #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When -seed flag isn't specified, use time.Now().UnixNano(). Use testing.TB.Logf() to display the seed, which will only show up with -v flag or upon error.
turbolent
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
Closes #104
Closes #189
Closes #203
Description
Use non-global rand.Rand for tests and benchmarks.
When
-seedflag isn't specified, usetime.Now().UnixNano()for seed non-global rand.Rand.Use
testing.T.Logf()to display the seed, which will only show up with -v flag or upon error. Otherwise, it won't be displayed.Refactored and renamed bencharkmarks.
Reran CI on GitHub about 7-8 times without hitting the intermittent ~1 hour timeout issue.
mainbranchFiles changedin the Github PR explorer