Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml #252

Merged
merged 2 commits into from
May 13, 2022
Merged

Update ci.yml #252

merged 2 commits into from
May 13, 2022

Conversation

fxamacker
Copy link
Member

@fxamacker fxamacker commented May 5, 2022

Description

  • Bump actions/checkout to v3.
  • Bump actions/setup-go to v3.
  • Add Go 1.18, remove Go 1.16 (test latest 3 versions).

fixes: #230


  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Bump actions/checkout to v3.
Bump actions/setup-go to v3.
Add Go 1.18, remove Go 1.16 (test latest 3 versions).
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #252 (e17fa83) into main (5494f9e) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   68.97%   68.90%   -0.07%     
==========================================
  Files          14       14              
  Lines        7245     7245              
==========================================
- Hits         4997     4992       -5     
- Misses       1617     1621       +4     
- Partials      631      632       +1     
Impacted Files Coverage Δ
storage.go 79.28% <0.00%> (-0.36%) ⬇️
map.go 71.31% <0.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5494f9e...e17fa83. Read the comment docs.

@turbolent
Copy link
Member

Nice!

Maybe we can also bump https:/onflow/atree/blob/main/go.mod#L3, e.g. to 1.17? See https://go.dev/doc/modules/gomod-ref#go-notes

(Once bumped, also need to run go mod tidy to update the go.sum file)

@fxamacker fxamacker merged commit 7a6063f into main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable additional lint checkers in golangci-lint
3 participants