Add MaxCollisionLimitPerDigest #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxCollisionLimitPerDigest is the noncryptographic hash collision limit (per digest per map) we can enforce in the first level. In the same map for the same digest, having a non-intentional collision should be rare and several collisions should be extremely rare. The default limit should be high enough to ignore accidental collisions while mitigating attacks. CollisionLimitError is returned when a new element first level hash points to a collision group which has already reached its max limit.
Codecov Report
@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 68.98% 69.34% +0.36%
==========================================
Files 14 14
Lines 7257 7344 +87
==========================================
+ Hits 5006 5093 +87
- Misses 1619 1622 +3
+ Partials 632 629 -3
Continue to review full report at Codecov.
|
turbolent
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of dapperlabs/atree-internal#4
mainbranchFiles changedin the Github PR explorer