Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more linters and fix reported issues #283

Merged
merged 5 commits into from
Jan 3, 2023

Conversation

fxamacker
Copy link
Member

Description

Added .golangci.yml to enable more linters in CI.
Fixed all reported issues.

Closes #281


  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker added tests improvement CI CI and GitHub Actions Workflows labels Jan 3, 2023
@fxamacker fxamacker self-assigned this Jan 3, 2023
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #283 (132dfb3) into main (cfaf052) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   68.99%   69.06%   +0.06%     
==========================================
  Files          14       14              
  Lines        7306     7306              
==========================================
+ Hits         5041     5046       +5     
+ Misses       1631     1627       -4     
+ Partials      634      633       -1     
Impacted Files Coverage Δ
errors.go 19.70% <ø> (ø)
storage.go 79.13% <ø> (+0.34%) ⬆️
array.go 76.15% <100.00%> (ø)
map.go 71.78% <100.00%> (+0.10%) ⬆️
map_debug.go 55.50% <100.00%> (ø)
settings.go 92.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fxamacker fxamacker merged commit 9a7600d into main Jan 3, 2023
@fxamacker fxamacker deleted the fxamacker/use-more-static-analysis branch March 5, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI and GitHub Actions Workflows improvement tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable extra linters and resolve reported issues
3 participants