Refactor hasPointer for register inlining
#327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, slab has pointer if any of its element is SlabIDStorable. This will become an issue with register inlining because even though inlined slab is not SlabIDStorable, it can contain SlabIDStorable. This commit: - adds containerStorable interface with hasPointer function - delegates each storable to check itself recursively - removes keyPointer and valuePointer fields from singleElement struct to simplify code and save 8 bytes per map element in memory
ramtinms
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #292
Description
Currently, slab has pointer if any of its element is
SlabIDStorable. This will become an issue with register inlining because even though inlined slab is notSlabIDStorable, it can containSlabIDStorable.This PR:
containerStorableinterface withhasPointerfunctionkeyPointerandvaluePointerfields fromsingleElementstruct to simplify code.mainbranchFiles changedin the Github PR explorer