Make smoke tests check recently added data deduplication feature #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some errors that should be returned as external error are being returned as fatal error. This caused a problem that was detected during Cadence integration. This commit resolves the problem by returning these fatal errors as external errors.
Some errors that should be returned as external error are being returned as fatal error. This caused a problem that was detected during Cadence integration. This commit resolves the problem by returning these fatal errors as external errors.
Cadence integration requires InlinedExtraData interface.
ContainerStorable interface supports encoding container storable (storable containing other storables) as element. This is needed for integration with Cadence.
This is needed for integration with Cadence because map key can be Cadence enums.
turbolent
approved these changes
Oct 19, 2023
ramtinms
approved these changes
Oct 19, 2023
turbolent
approved these changes
Oct 20, 2023
Update for Cadence integration for atree inlining and deduplication
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #349
Updates epic #292 and issue #296
Currently, the data deduplication feature added by PR #342 is not being checked by smoke tests. We need to smoke test encoding/decoding to the new compact map format (which deduplicates nested Cadence composite types).
This PR adds nested composite types to smoke tests and checks encoding/decoding with the new compact map format to test data deduplication.
mainbranchFiles changedin the Github PR explorer