Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ContainerStorable.EncodeAsElement #354

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Remove ContainerStorable.EncodeAsElement #354

merged 3 commits into from
Oct 24, 2023

Commits on Oct 22, 2023

  1. Remove ContainerStorable.EncodeAsElement 

    Currently, EncodeAsElement is used to encode inlined array and map,
while Encode is used to encode standalone array and map.

This commit simplifies encoding API by using Encode() to encode
both inlined/standalone array/map.
    @fxamacker
    fxamacker committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    d718306 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Create Encoder.inlinedExtraData lazily

    @fxamacker
    fxamacker committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d88bd12 View commit details
    Browse the repository at this point in the history

  2. Fail StorableSlab.Encode() with inlined array/map 

    This commit makes StorableSlab.Encode() return
error if it contains inlined array or inlined map.
    @fxamacker
    fxamacker committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    acdb685 View commit details
    Browse the repository at this point in the history