Fix SlabIterator to include nested storage ID (non-inlining feature branch) #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlabIterator is used by storage health check, which is used for tests and for new migration features like filtering out old unreferenced slabs, etc. Currently, SlabIterator doesn't traverse deep enough to handle nested storage ID inside another storable such as Cadence SomeValue. This commit fixes this by handling nested storage ID in element such as Cadence SomeValue.
ramtinms
approved these changes
Apr 29, 2024
|
@fxamacker Does this PR still need to get ported to another feature branch? |
@turbolent No, because this was already in the atree-inlining feature branch (I used this to iterate atree inlined slabs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #397
This problem does not affect atree inlining feature branch.
SlabIteratoris used by storage health check, which is used for tests and for new migration features like filtering out old unreferenced slabs, etc.Currently,
SlabIteratordoesn't traverse deep enough to handle nested storage ID inside another storable such as CadenceSomeValue.This PR updates SlabIterator to handle nested storage ID in element such as Cadence
SomeValue.mainbranchFiles changedin the Github PR explorer