Fix migration filter for old unreferenced slabs (non-inlining feature branch) #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration programs in onflow/flow-go added a flag to filter old unreferenced slabs and onflow/atree added some functions to support that. However, some of the old unreferenced slabs are not filtered during migration. This commit fixes the migration filter by handling nested storage ID inside element such as Cadence SomeValue.
ramtinms
approved these changes
Apr 29, 2024
fxamacker
changed the base branch from
fxamacker/traverse-deeper-in-slab-iterator
to
feature/stable-cadence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #395
Recently, migration programs in
onflow/flow-goadded a flag to filter out old unreferenced slabs andonflow/atreeadded some functions to support that. However, some of the old unreferenced slabs are not filtered.This issue only affects this new migration feature in
onflow/flow-go:This PR fixes the migration filter by handling nested storage ID inside element such as Cadence SomeValue.
mainbranchFiles changedin the Github PR explorer