Fix data race in account grouping for account based migration #5488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5488 +/- ##
==========================================
+ Coverage 55.97% 56.02% +0.05%
==========================================
Files 1022 1029 +7
Lines 99705 100434 +729
==========================================
+ Hits 55807 56267 +460
- Misses 39598 39836 +238
- Partials 4300 4331 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fxamacker
changed the title
janezpodhostnik
approved these changes
Mar 1, 2024
| @@ -177,17 +177,17 @@ func (s sortablePayloads) Swap(i, j int) { | |||
| s[i], s[j] = s[j], s[i] | |||
| } | |||
|
|
|||
| func (s sortablePayloads) FindNextKeyIndex(i int) int { | |||
| func (s sortablePayloads) FindNextKeyIndexUntil(i int, upperBound int) int { | |||
There was a problem hiding this comment.
ah, I see, Good catch!
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5485
Updates onflow/cadence#3096
This fixes data race in account grouping.
While at it, also added test to reproduce the data race.