Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Moving MyBatis cache implementation to Spring Caching #133

Open
aweigold opened this issue Jul 17, 2019 · 1 comment
Open

Discussion: Moving MyBatis cache implementation to Spring Caching #133

aweigold opened this issue Jul 17, 2019 · 1 comment
Assignees

Comments

@aweigold
Copy link
Contributor

The current RedisCache implementation is utilizing a Spring managed RedisTemplate, causing awkward interaction between the MyBatis managed RedisCache instance and dependency injection.

Spring offers caching abstractions, which utilize Redis, which can be wrapped around the DAO layers. This also allows for some greater configurability (easily change caching vendors, rules, or even turning it on/off).

Is this refactor of interest to the project?

@NashMiao NashMiao self-assigned this Jul 18, 2019
@NashMiao
Copy link
Contributor

@aweigold Thanks for your help, let's continue to move on.

I think moving MyBatis cache implementation to Spring Caching is a better choice.

I have a question, If we move to Spring Caching, whether can we use declarative annotation-based caching which introduce in here.

If we can, let's refactor it together. Maybe we can list a TODO list in this issue to remind us not omission something important during refacing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants