feat: add Prefab provider #575
Conversation
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
There was a problem hiding this comment.
@liran2000 I left a couple notes but overall this LGTM and (once I got the provider set up properly) works as intended.
Thanks for your efforts here! 💙
Signed-off-by: liran2000 <[email protected]>
…contrib into feature/prefab
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: liran2000 <[email protected]>
Signed-off-by: Liran M <[email protected]>
| // TODO | ||
| // t.Run("sample_json", func(t *testing.T) { | ||
| // value, err := ofClient.ObjectValueDetails(context.Background(), "sample_json", map[string]interface{}{ | ||
| // "nested": "value", | ||
| // }, evalCtx) | ||
| // require.Equal(t, []string{"a", "b"}, value.Value) | ||
| // require.Nil(t, err) | ||
| // }) |
There was a problem hiding this comment.
There was a problem hiding this comment.
yes, can leave it for now, and will track to see when can be enhanced with the additional tests.
| // EnvironmentNames []string | ||
| // ProjectEnvID int64 | ||
| // InitializationTimeoutSeconds float64 | ||
| // OnInitializationFailure OnInitializationFailure |
There was a problem hiding this comment.
Should this be removed or is there a reason to keep it? Perhaps comment a TODO if so?
There was a problem hiding this comment.
Can you add a component_owners entry for this with yourself and @semanticart if they agree?
Approved otherwise. Thanks!
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Liran M <[email protected]>
Signed-off-by: Liran M <[email protected]>
@semanticart added you as well :) thanks ! |
Readme describes the provider.