revert clonable change

Signed-off-by: Kavindu Dodanduwa <[email protected]>
open-feature · Feb 13, 2024 · 16fe055 · 16fe055
1 parent 47c752d
commit 16fe055
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/main/java/dev/openfeature/sdk/ImmutableStructure.java b/src/main/java/dev/openfeature/sdk/ImmutableStructure.java
@@ -40,7 +40,7 @@ public ImmutableStructure(Map<String, Value> attributes) {
  .collect(HashMap::new,
  (accumulated, entry) -> accumulated.put(entry.getKey(),
  Optional.ofNullable(entry.getValue())
- .map(Value::copy)
+ .map(Value::clone)
  .orElse(null)),
  HashMap::putAll)));
  }
@@ -54,7 +54,7 @@ public Set<String> keySet() {
  @Override
  public Value getValue(String key) {
  Value value = this.attributes.get(key);
- return value != null ? value.copy() : null;
+ return value != null ? value.clone() : null;
  }
 
  /**
@@ -70,7 +70,7 @@ public Map<String, Value> asMap() {
  .collect(HashMap::new,
  (accumulated, entry) -> accumulated.put(entry.getKey(),
  Optional.ofNullable(entry.getValue())
- .map(Value::copy)
+ .map(Value::clone)
  .orElse(null)),
  HashMap::putAll);
  }

diff --git a/src/main/java/dev/openfeature/sdk/Value.java b/src/main/java/dev/openfeature/sdk/Value.java
@@ -20,7 +20,7 @@
 @ToString
 @EqualsAndHashCode
 @SuppressWarnings({"PMD.BeanMembersShouldSerialize", "checkstyle:MissingJavadocType", "checkstyle:NoFinalizer"})
-public class Value {
+public class Value implements Cloneable {
 
  private final Object innerObject;
 
@@ -262,12 +262,13 @@ public Instant asInstant() {
  }
 
  /**
- * Perform a deep copy of this value.
+ * Perform deep clone of value object.
  *
  * @return Value
  */
  @SneakyThrows
- protected Value copy() {
+ @Override
+ protected Value clone() {
  if (this.isList()) {
  List<Value> copy = this.asList().stream().map(Value::new).collect(Collectors.toList());
  return new Value(copy);