chore: various improvements as suggested by sonar

src/main/java/dev/openfeature/sdk/EventSupport.java

@@ -163,8 +163,8 @@ static class HandlerStore {
 
  private final Map<ProviderEvent, List<Consumer<EventDetails>>> handlerMap;
 
- {
- handlerMap = new ConcurrentHashMap<ProviderEvent, List<Consumer<EventDetails>>>();
+ HandlerStore() {
+ handlerMap = new ConcurrentHashMap<>();
  handlerMap.put(ProviderEvent.PROVIDER_READY, new ArrayList<>());
  handlerMap.put(ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, new ArrayList<>());
  handlerMap.put(ProviderEvent.PROVIDER_ERROR, new ArrayList<>());

src/main/java/dev/openfeature/sdk/ImmutableStructure.java

@@ -40,7 +40,7 @@ public ImmutableStructure(Map<String, Value> attributes) {
  .collect(HashMap::new,
  (accumulated, entry) -> accumulated.put(entry.getKey(),
  Optional.ofNullable(entry.getValue())
- .map(e -> e.clone())
+ .map(Value::clone)
  .orElse(null)),
  HashMap::putAll)));
  }
@@ -70,7 +70,7 @@ public Map<String, Value> asMap() {
  .collect(HashMap::new,
  (accumulated, entry) -> accumulated.put(entry.getKey(),
  Optional.ofNullable(entry.getValue())
- .map(e -> e.clone())
+ .map(Value::clone)
  .orElse(null)),
  HashMap::putAll);
  }

src/main/java/dev/openfeature/sdk/MutableContext.java

@@ -145,7 +145,7 @@ public MutableStructure add(String ignoredKey, List<Value> ignoredValue) {
  return null;
  }
 
- public MutableStructure add(String ignoredKey, MutableStructure ignoredValue) {
+ public MutableStructure add(String ignoredKey, Structure ignoredValue) {
  return null;
  }
 

src/main/java/dev/openfeature/sdk/MutableStructure.java

@@ -75,7 +75,7 @@ public MutableStructure add(String key, Structure value) {
  return this;
  }
 
- public <T> MutableStructure add(String key, List<Value> value) {
+ public MutableStructure add(String key, List<Value> value) {
  attributes.put(key, new Value(value));
  return this;
  }

src/main/java/dev/openfeature/sdk/NoOpProvider.java

@@ -18,12 +18,7 @@ public ProviderState getState() {
 
  @Override
  public Metadata getMetadata() {
- return new Metadata() {
- @Override
- public String getName() {
- return name;
- }
- };
+ return () -> name;
  }
 
  @Override

src/main/java/dev/openfeature/sdk/ProviderRepository.java

@@ -168,7 +168,6 @@ private boolean isProviderRegistered(FeatureProvider provider) {
  private void shutdownProvider(FeatureProvider provider) {
  taskExecutor.submit(() -> {
  try {
- // detachProviderEvents(provider);
  provider.shutdown();
  } catch (Exception e) {
  log.error("Exception when shutting down feature provider {}", provider.getClass().getName(), e);

src/main/java/dev/openfeature/sdk/Value.java

@@ -266,7 +266,6 @@ public Instant asInstant() {
  *
  * @return Value
  */
-
  @SneakyThrows
  @Override
  protected Value clone() {

src/main/java/dev/openfeature/sdk/providers/memory/InMemoryProvider.java

@@ -52,6 +52,7 @@ public InMemoryProvider(Map<String, Flag<?>> flags) {
  * @param evaluationContext evaluation context
  * @throws Exception on error
  */
+ @Override
  public void initialize(EvaluationContext evaluationContext) throws Exception {
  super.initialize(evaluationContext);
  state = ProviderState.READY;