[Enhancement]Replace numpy ascontiguousarray with torch contiguous to speed-up #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge MMSegmentation 1.x development branch dev-1.x to main branch 1.x for v1.0.0rc2
|
|
Codecov ReportBase: 83.25% // Head: 83.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2604 +/- ##
===========================================
+ Coverage 83.25% 83.35% +0.09%
===========================================
Files 145 145
Lines 8505 8508 +3
Branches 1273 1274 +1
===========================================
+ Hits 7081 7092 +11
+ Misses 1213 1202 -11
- Partials 211 214 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MeowZheng
approved these changes
Feb 15, 2023
MeowZheng
changed the title
aravind-h-v
pushed a commit
to aravind-h-v/mmsegmentation
that referenced
this pull request
Mar 27, 2023
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
… speed-up (open-mmlab#2604) ## Motivation Original motivation was after [MMDetection PR #9533](open-mmlab/mmdetection#9533) With several experiments I found out that if a ndarray is contiguous, numpy.transpose + torch.contiguous perform better, while if not, then use numpy.ascontiguousarray + numpy.transpose ## Modification Replace numpy.ascontiguousarray with torch.contiguous in [PackSegInputs](https:/open-mmlab/mmsegmentation/blob/1.x/mmseg/datasets/transforms/formatting.py) Co-authored-by: MeowZheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Original motivation was after MMDetection PR #9533
With several experiments I found out that if a ndarray is contiguous, numpy.transpose + torch.contiguous perform better, while if not, then use numpy.ascontiguousarray + numpy.transpose
Modification
Replace numpy.ascontiguousarray with torch.contiguous in PackSegInputs